Session not closed in class-billmate-cardpay.php
matteth opened this issue · 6 comments
WordPress Health check reports: A PHP session was created by a session_start() function call. This interferes with REST API and loopback requests. The session should be closed by session_write_close() before making any HTTP requests.
The error seems to be that the "session_start()" in class-billmate-cardpay.php isn't closed. When session_write_close() is added to the end of the file the error disappears.
@matteth Good luck! I've been trying to get this fixed a long time. :)
See possible fix in #286. But Billmate says there is an issue with Billmate Checkout using that fix.
Last time I heard, they said they will split custom pay and the checkout into two plugins and then it can be fixed in the custom pay plugin. But it seems you're using the checkout?
@Mattet Well this one is important to fix! For us it messes up Mailchimp sync. :(
So I always have to patch it after updating..
We are currently developing a new Billmate Checkout plugin for Woocommerce. This will not have that issue. Will keep you posted!
This is now fixed with release: https://github.com/Billmate/woocommerce/releases/tag/3.11.3
Re-open as the fix was reverted?