Unable to launch electron apps such as Discord

Question

Unable to launch electron apps such as Discord

afzalarsalan opened this issue 3 years ago · 6 comments

Due to #54, I notice that some electron apps such as Discord no longer seem to launch at all.

In particular the error I get is
exec: cd: not found

This issue doesn't occur with 1.5.2.

Answer 1 · 2021-10-27T21:50:26.000Z

It seems that this issue directly correlates with the presence of a PATH variable in the .desktop file. When commenting out either or both PATH declarations in the file, the program seems to launch normally.

Answer 2 · 2021-10-27T22:41:53.000Z

The stem of the issue derives from the fact that generate_command() prepends cd to the final parsed command which isn't understood by exec due to cd being a shell primitive and not a binary.

Answer 3 · 2021-10-28T04:49:20.000Z

Thanks for debugging. I guess I will revert the release until we figure something out

Answer 4 · 2021-10-28T20:28:27.000Z

@afzalarsalan Does it fix the problem if you change this line
from

if(path){ printf "cd " path " && " }

to

if(path){ printf "env PWD=" path }

Answer 5 · 2021-10-28T21:00:53.000Z

Sorry about this, I hadn't hit a desktop file with Path= in my tests. It should work now for those as well.

Answer 6 · 2021-10-28T23:26:23.000Z

@afzalarsalan Does it fix the problem if you change this line from
if(path){ printf "cd " path " && " }
to
if(path){ printf "env PWD=" path }

Unfortunately I can confirm that this fix does not work to resolve the issue, however I can confirm that #56 does end up resolving the issue appropriately