Bisonai/orakl

Fix github action trigger

Closed this issue · 1 comments

https://github.com/Bisonai/orakl/actions/workflows/contracts.test.yaml
seen from github action, it was kept triggered with unrelated path updates

In official docs for github actions (https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore), it's written as followed

If you define both branches/branches-ignore and paths/paths-ignore, the workflow will only run when both filters are satisfied

yet, trigger defined as followed in contracts.test.yaml seems to be running all the time whenever there's a updates on different branches. even when there's an update in files not in contracts folder

on:
  push:
    branches-ignore:
      - "master"
    paths:
      - "contracts-v0.1/**"
      - "!contracts-v0.1/**/VRFCoordinator.sol"
      - "!contracts-v0.1/**/VRFConsumerBase.sol"
      - "!contracts-v0.1/**/vrf/**"
image image

and paths are also defined as written in official docs
(https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-and-excluding-paths)

Image

the workflow has been updated to the following: https://github.com/Bisonai/orakl/actions/workflows/contracts.test+publish.yaml

According to the last few runs of this flow, the patterns match. Please, create the issue again if it happens again.