bevy main branch
Closed this issue ยท 5 comments
Just found this repo, looking forward to using it.
Thoughts on a bevy main branch? Created a fork that works with main currently.
Notes:
- Had to add a wrapper to CameraRig for Component unless I am missing something.
- Updated QuerySets, some were not filtered and returning the
With<?>
, I realize it has no effect really, was it there for reason?
The query state changes lead to code like this, is there a cleaner way to handle E0716
let mut q2 = query.q2();
let mut rig = q2.single_mut();
rig.0.driver_mut.....
Looking good! I haven't been looking at migrating to main before I was sure that the 0.6 was going to be released soon. But this is a great contribution! ๐ I've created a 0.6
branch that you're very welcome to make a pull request to that branch I made the pr #5.
About the notes:
- Yes, Component derive is required now, so that is correct
- I'm not sure if I understand correctly, I'm using the
With
filter so when people use the example and create another camera, the newly added camera will not be affected bybevy_dolly
In terms of query state, I haven't been looking into it, so I wound't know. Though E0716 can always be handled by rearranging calls and create an immutable variable, you can look at this example in the agn_systems
branch.
I kinda started refactoring to fix a few things and couldn't stop. I tried to keep to the spirit of everything that was there, thoughts?
https://github.com/slyedoc/bevy_dolly/tree/bevy-native
Pretty sure everything works now, except cursor capture.
And the reason I would like a "bevy-main" branch would be nice is that people will always track on main, even after 0.6 releases, with a bevy-main, we can just pull from "bevy-main" master for a release and keep plugging.
Nice work! and yes, I have a lot of thoughts ๐ . If you could make a pr to 0.6 that would be great, cause then I can more easily comment and review your work and any future modifications you might have prior to merging.
Also, I agree with a bevy-main
branch, given that the release cycle of each version is gonna take time, this makes a lot of sense. Though I can't promise that everything always is going to be up-to-date with main and might not be, currently, viable for a lot of plugin maintainers imo. A fix for this would be bevy starting to use 0.6.1
(on GitHub, not as a crate version) to keep some stability for plugin maintainers and only change to 0.6.2
if there is breaking changes from the previous update.
I'll try to see if I can get some opinions on this topic in the community on discord.
The release cycle has now been discussed and is now in motion ๐
bevyengine/bevy#2972
Going to do a total refactor using 0.7's newtype and will match better with main, giving dolly a better upstream potential