Setup Azure Pipelines + code review
StefH opened this issue · 5 comments
Hello @chrissainty,
Can you configure the azire-pipelines and update the readme with the correct id?
And probably do a code-review on the initial checkin...
No problem at all.
Code review
Everything looks really good!
I have a slight concern with the testing as the types you're using will change and probably break. I would suggest looking at the prototype testing library Steve Sanderson has produced. It's probably going to be the base for the future unit test framework produced by the ASP.NET team.
Another comment is that I would probably have used a .razor
file for the component. Using BuildRenderTree
directly isn't a recommended practice. But I'm happy to leave that choice up to you.
Lastly, in terms of naming. We could just call it Label
component are case sensitive now so there would be no issue with naming collisions with the standard HTML label
element. What do you think?
Just noticed, you've not updated the NuGet description in the .csproj
file.
Azure Pipelines
I've configure the build pipeline and updated the build badge in the readme. When do you want to publish the first release?
Thanks for review, for me building Blazor components is new, so all tips are welcome.
1] I'll take a look at that unittest framework, to see if I can use this.
2] I did not think of creating a .razor
file, I based my code on code from Microsoft. I'll see if I can rewrite the code to a .razor
file
3] I think I tried to name the component just Label
, but I think I got some weird compile errors... I'll double check.
4] I'll fix the csproj
1] Done, see PR
2] I keep it like it is.
3] I keep it like it is.
4[ Done, see PR