BlitterStudio/MB_SubSonic

Hex encoded password should report 1.12 api version

Closed this issue · 3 comments

Hello,

I guess the option "hex encoded password" is used to support old servers or servers that do not provide the new authentication scheme.
However the client api is still set to 1.13, and servers that stick to 1.12 or older complain about the version.

Therefore I think we should report api version 1.12 when the hex encoded password scheme is selected.

Hi, just an addition, I cannot get through in MusicBee of the Detected a SubSonic server if this helps.

Here is a log example of what I get on the demo server (demo/demo) when using a hex encoded password:

[2020-Jan-06 18:56:51.986] "GET /rest/getPlaylists.view?u=demo&p=enc%3a64656D6F&v=1.13.0&c=MusicBee HTTP/1.1" 200 205```

[2020-Jan-06 18:56:51.984] 1595 - [error] - [API_SUBSONIC] Error while processing request 'getPlaylists', params = [{c=MusicBee}, {p=*SENSIBLE DATA*}, {u=demo}, {v=1.13.0}, ], code = 30, msg = 'Incompatible Subsonic REST protocol version. Server must upgrade.'

Thanks, I'll look into this after I'm finished with a few other projects I'm in the middle of.