Blockchain-Technology-Lab/consensus-decentralization

Ethereum mapping multiple keys

Closed this issue · 3 comments

Check if possible for entity not to have a value in pool_links.keys() (L46, src/mappings/ethereum.py).

Same for bitcoin mapping (L59)

It is possible, so closing this issue. pool_links corresponds to legal links or clusters. If an entity is standalone, it will not appear in pool_links (but will appear in pool_data).

I think my initial comment was misunderstood. I meant whether it's possible for entity not to have been defined at all, in which case an error would be raised when trying to check if it's in pool_links.keys(). So what I'm saying is that if the condition at L40 is not met (if not pool_match) then the variable entity will never have been initialized.