Blockstream/green_android

Terms and policies are not links in all locales

Closed this issue · 8 comments

...currently it's just an odd checkbox that doesn't seem to mean anything

You mean this checkbox?

No, this checkbox:

3b22d5bc_x7Z6kimORX-A06f9wBcYSw

PS: I don't use your locale

No, this checkbox:

3b22d5bc_x7Z6kimORX-A06f9wBcYSw

PS: I don't use your locale

It's a translation issue.

Is that correct "Sunt de acord cu Condiții de utilizare și Politică de Confidențialitate"?

no, please look at the colours... read issue title again :)

no, please look at the colours... read issue title again :)

We do a search and replace, so all links in I agree to the Terms of Service and Privacy Policy like Terms of Service & Privacy Policy should be localized.

So adding the Romanian translation will fix the issue.

So adding the Romanian translation will fix the issue.

Yeah, but do a add a fallback to English if the translated ones are not yet available

So adding the Romanian translation will fix the issue.

Yeah, but do a add a fallback to English if the translated ones are not yet available

The current approach has some limitations, until we do a refactor, this is the only solution.

Current approach works only if all or none of the strings used are translated. If some are translated and some are not, the replacement breaks.

Fixed in 4cd29f9