Tracing macros
Opened this issue · 1 comments
DimitriPapadopoulos commented
Describe the bug
I am not sure I understand the tracing macros:
Lines 114 to 129 in 3ae32b6
BLOSC_ERROR
callsBLOSC_TRACE_ERROR
, which prints only if environment variableBLOSC_TRACE
is definedBLOSC_INFO
prints directly if environment variableBLOSC_INFO
is defined. Instead, I think it should callBLOSC_TRACE_INFO
, which prints only if environment variableBLOSC_TRACE
is defined.
I realise that it's probably unfeasible to modify things without slightly breaking backwards compatibility, but the current macros don't make sense to me: if environment only variable BLOSC_INFO
is defined, BLOSC_INFO
will print but BLOSC_ERROR
will not print!
FrancescAlted commented
I like your proposal of making interfaces more uniform. Right now BLOSC_INFO
should not be used beyond developers, so I don't think we will break anything serious if we implement what you are proposing. Would you mind sending a PR?