Windows build fails if path contains spaces
rakiru opened this issue · 3 comments
When attempting to install Lua, the path isn't quoted, so fails. Everything up to this point correctly quotes paths and works fine.
==> Starting package()...
cd src && mkdir -p C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/bin C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/include C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/lib C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/share/man/man1 C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/share/lua/5.2 C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/lib/lua/5.2
cd src && install -p -m 0755 lua.exe luac.exe lua52.dll C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/bin
install: omitting directory ‘C:/Users/Sean/My’
Makefile:61: recipe for target 'install' failed
make: *** [install] Error 1
==> ERROR: A failure occurred in package().
Aborting...
Failed to build lua
I've confirmed it appears to build correctly on my system in a path without spaces.
if there are spaces in the file Path, you have to use quotation marks ("my path"), otherwise the command line thinks, there are two arguments
So, not too sure how fixable this is, I'm guessing the issue lies in Lua's Makefile, nothing immediately stands out from the MINGW PKGBUILD and patches, I'll look into this though and apologies for the delay.
if there are spaces in the file Path, you have to use quotation marks ("my path"), otherwise the command line thinks, there are two arguments
@Henny022 he realized this, and he opened the issue because the path is not quoted. He doesn't have control over whether it's quoted or not (as far as I can tell)