BobBuildTool/basement

doxygen build in sandbox fails

Closed this issue · 1 comments

Hey,

I can't built devel::doxygen in sandbox with the following error message:

CMake Error at /bob/57ddf4ba5fedc6cc2911e0f7ffca701259a88072/workspace/usr/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:164 (message):
  Could NOT find Iconv (missing: ICONV_TEST ICONV_INCLUDE_DIR)
Call Stack (most recent call first):
  /bob/57ddf4ba5fedc6cc2911e0f7ffca701259a88072/workspace/usr/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:445 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindIconv.cmake:87 (find_package_handle_standard_args)
  CMakeLists.txt:120 (find_package)

this is fixed in with this for me: https://github.com/BobBuildTool/basement/pull/78/files

# We should also add the sysroot path of gcc/g++ if available.
if [[ "$CXX" == *"g++" ]] ; then
SYSROOT="$($CXX -print-sysroot)"
fi
[ -z "${SYSROOT:+true}" ] || CMAKE_FIND_ROOT_PATH+=";${SYSROOT}"

is this fine for an integration into the master?

This looks reasonable. But the comment should explain why the sysroot must be added. It is because our host-compat-toolchain has a non-standard sysroot even though it's a native compiler (which is actually a lie but close enough). In that sense it should be sufficient to restrict it to the $CC == gcc case...