BobBuildTool/bob

wrong windows/MSYS whitelisted environment variable names

mahaase opened this issue · 0 comments

bob/pym/bob/input.py

Lines 3095 to 3099 in 056cf29

self.__whiteList |= set(["ALLUSERSPROFILE", "APPDATA",
"COMMONPROGRAMFILES", "COMMONPROGRAMFILES(X86)", "COMSPEC",
"HOMEDRIVE", "HOMEPATH", "LOCALAPPDATA", "PATH", "PATHEXT",
"PROGRAMDATA", "PROGRAMFILES", "PROGRAMFILES(X86)", "SYSTEMDRIVE",
"SYSTEMROOT", "TEMP", "TMP", "WINDIR"])

win | msys
CommonProgramFiles | COMMONPROGRAMFILES
CommonProgramFiles(x86) | CommonProgramFiles(x86)
ProgramFiles | PROGRAMFILES
ProgramFiles(x86) | ProgramFiles(x86)
Path | PATH
ProgramData | ProgramData
SystemDrive | SYSTEMDRIVE
SystemRoot | SYSTEMROOT
windir | WINDIR

The win-variant is not case-sensitive in native windows, but the MSYS-variant is case sensitive!!
Becuase the names are not consistent, we should add always both variants of each.
"windir" is all lower-case.. funny mhh? :D

would we add this one too?
PROCESSOR_ARCHITECTURE necessary for some libraries like boost >= 1.76.0