BoldGrid/boldgrid-theme-framework

class 'Boldgrid_Framework_Activate' does not have a method 'reset'

bwmarkle opened this issue · 4 comments

Inspirations triggers a reset via:

do_action( 'boldgrid_framework_reset', true );

In class-boldgrid-framework we're still adding:

$this->loader->add_action( 'boldgrid_framework_reset', $activate, 'reset' );

... even though the reset method has been removed, which is causing the following error:

PHP Warning:  call_user_func_array() expects parameter 1 to be a valid callback, class 'Boldgrid_Framework_Activate' does not have a method 'reset' in /home/public_html/wp-includes/class-wp-hook.php on line 288
PHP Stack trace:
PHP   1. {main}() /home/public_html/wp-admin/admin.php:0
PHP   2. do_action() /home/public_html/wp-admin/admin.php:254
PHP   3. WP_Hook->do_action() /home/public_html/wp-includes/plugin.php:478
PHP   4. WP_Hook->apply_filters() /home/public_html/wp-includes/class-wp-hook.php:312
PHP   5. Boldgrid_Inspirations_Built->inspiration_page() /home/public_html/wp-includes/class-wp-hook.php:288
PHP   6. Boldgrid_Inspirations_Inspiration->deploy_script() /home/public_html/wp-content/plugins/boldgrid-inspirations/includes/class-boldgrid-inspirations-built.php:698
PHP   7. include() /home/public_html/wp-content/plugins/boldgrid-inspirations/includes/class-boldgrid-inspirations-inspiration.php:470
PHP   8. Boldgrid_Inspirations_Deploy->do_deploy() /home/public_html/wp-content/plugins/boldgrid-inspirations/pages/deploy.php:81
PHP   9. Boldgrid_Inspirations_Deploy->start_over() /home/public_html/wp-content/plugins/boldgrid-inspirations/includes/class-boldgrid-inspirations-deploy.php:2329
PHP  10. Boldgrid_Inspirations_Start_Over->start_over() /home/public_html/wp-content/plugins/boldgrid-inspirations/includes/class-boldgrid-inspirations-deploy.php:1117
PHP  11. Boldgrid_Inspirations_Start_Over->reset_framework() /home/public_html/wp-content/plugins/boldgrid-inspirations/includes/class-boldgrid-inspirations-start-over.php:302
PHP  12. do_action() /home/public_html/wp-content/plugins/boldgrid-inspirations/includes/class-boldgrid-inspirations-start-over.php:355
PHP  13. WP_Hook->do_action() /home/public_html/wp-includes/plugin.php:478
PHP  14. WP_Hook->apply_filters() /home/public_html/wp-includes/class-wp-hook.php:312

Was the reset class moved somewhere, or removed all together?

It looks like the reset() method was removed in 16675ca

Would you prefer that I just get rid of the action all together, or that I put the reset() method back where it was?

My initial thought was to remove the action.

My initial thought was to remove the action.

Can do