BoldGrid/boldgrid-theme-framework

Continued padding / margin fixes in Crio

nicolepaschen opened this issue · 13 comments

  • PPBP Section sliders have horizontal scrollbar but only with Crio

  • Check the alignment of Custom Page Header Sample Layouts

  • Sticky Header menu background doesn't touch the sides

There is padding on the row, column, AND container on mobile: image

This is slightly more padding on the sides than we want. I removed it from the container and it looks like this:
image

I have the same layout on standard and sticky header but the Site Title jumps like 15px

sticky-headeer-vs-standard

Menu jumps too
menu-too

Editor:
image

Front End:
image

also see #357

The margin at the top was zero-ed out so it would line up with the page content. It should only be added to the first widget title.

not-enough-margin
first-of-type-only

For horizontal lines - they are in nested row code but they shouldn't get the negative margin applied like other nested rows
hr-code
hr-display

This is a hr in a nested row. It looks correct:
image

This is still happening along with the menu jump - the sticky header container is slightly bigger than the standard:

#347 (comment)

PPBP Section sliders have horizontal scrollbar but only with Crio

  • Sections should be full width
  • Navigation buttons NOT set to overlay
  • see scrollbar

Sticky Header menu background doesn't touch the sides

When using the Coherent Inspiration, the standard header is full width so the menu background row touches the sides. I cannot get a sticky header to match this design, bc the sticky header menu background is contained to the menu items. Please have it span the entire length so sticky and standard can match.

sticky-header-menu-background

Custom Page Header Sample Layout 3 - please remove the top 15px of padding on the row.

This is a content slider which is a nested row - something is messing up the margins making the content no longer exactly centered:

not-centered

I started with the Callaway Inspiration. When I changed the header to the default side header layout, I have a scrollbar at the bottom of my screen on tablet and desktop.