Boulder-Investment-Technologies/lppls

Support for Windows

Closed this issue · 6 comments

nightvision04 commented

Currently we only platform test for ubuntu-latest. Could we expand the yml to include windows-latest?

Joshwani commented

Yeah, definitely, is that as simple as adding it to the .yml?

nightvision04 commented

Yep. You can test ubuntu-latest and windows-latest like this for example:

  job1:
    runs-on: ubuntu-latest
    steps:
    - id: step1
      run: echo "::set-output name=test::lppls for ubuntu"

  job2:
    runs-on: windows-latest
    steps:
    - id: step1
      run: echo "::set-output name=test::lppls for windows"
nightvision04 commented

If you want to get fancy with supporting multiple python versions on each, then it looks more like this:

  job1:
    runs-on: ubuntu-latest
    strategy:
          matrix:
            python-version: [3.6, 3.7, 3.8]
    steps:
    - id: step1
      run: echo "::set-output name=test::lppls for ubuntu"

  job2:
    runs-on: windows-latest
    strategy:
          matrix:
            python-version: [3.6, 3.7, 3.8]
    steps:
    - id: step1
      run: echo "::set-output name=test::lppls for windows"
nightvision04 commented

What you've made here is really great @Joshwani , and I think it will get some well deserved exposure if we expand the platform/version support like this. :)

Joshwani commented

Thanks @nightvision04! I appreciate all your help.

  • 👍1