Branch crash on macCatalyst on skAdNetworkUpdatePostbackConversionValueCoarseValueLockWindow
sergiocampama opened this issue · 3 comments
sergiocampama commented
Describe the bug
The new API for skAdNetworkUpdatePostback:coarseValue:lockWindow is properly guarded for iOS 16.1, but it's not guarded for macCatalyst 16.1, so Copilot macOS app crashes on users that are on macOS 13.0. Could this guard be added to the check in line 108 of file BNCSKAdNetwork.m?
Steps to reproduce
- Integrate pod Branch at version 1.45.2
- Use on a catalyst app on macOS 13.0
- Invoke the skAdNetworkUpdatePostbackConversionValueCoarseValueLockWindow call
Expected behavior
To not crash.
SDK Version
1.45.2
XCode Version
14.0, but irrelevant
Device
macOS
OS
13.0
Additional Information/Context
No response
sergiocampama commented
btw, if you use API_DEPRECATED("This is no longer supported for iOS 16.1+ - SKAN4.0", ios(13.0, 16.0), macCatalyst(13.0, 16.0)) instead to deprecate APIs, clients will be able to better guard those calls resulting in less build warnings
echo-branch commented
@sergiocampama
Thanks for the heads up, we'll work to get this into the next patch.
echo-branch commented
This should be fixed in 2.1.2