Branch.h: Pointer is missing a nullability type specifier

Question

Branch.h: Pointer is missing a nullability type specifier

Closed this issue 5 years ago · 16 comments

Just upgraded to 0.29.0 from 0.27.1 and now I'm getting hundreds of errors concerning the lack of nullability specifiers in Branch.h.

The very first error is:

Pods/Headers/Public/Branch/Branch.h:72:17: Pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified)

Xcode 10.3
CocoaPods 1.7.5

Answer 1 · 2019-10-01T12:43:14.000Z

Looks to be a new issue in 0.29.0, I just tried 0.28.1 and it compiles without error.

Answer 2 · 2019-10-01T15:54:06.000Z

I have a backlogged ticket for those warnings. The warning setting in Xcode 11 changed, just didn't have time to get it done in time for 0.29.0. It will be in the next release.

Answer 3 · 2019-10-01T16:06:24.000Z

I'm still using Xcode 10.3.

Answer 4 · 2019-10-01T16:28:39.000Z

I mean when I opened the SDK in Xcode 11, it updated the warning settings and I shipped with those new settings.

Answer 5 · 2019-10-02T22:35:29.000Z

i also have this problem.
Please let us know when this is fixed.
thanks!

Answer 6 · 2019-10-03T17:03:15.000Z

FYI, I've added -Xcc -Wno-nullability-completeness to "Other Swift Flags" in my project to suppress these warnings until this gets patched. Hope this helps someone.

Answer 7 · 2019-10-04T14:18:53.000Z

Same issue. Waiting for solution! Thanks

Answer 8 · 2019-10-04T15:34:01.000Z

A fix for this is in a branch and being reviewed/tested.

Answer 9 · 2019-10-04T15:46:13.000Z

@echo-branch Thanks for notice!

Answer 10 · 2019-10-07T07:24:27.000Z

Hey Team,

The Branch.getInstance() property is now optional, is that the desired behavior? As any call will look like Branch.getInstance()?.doSomething().

Thanks

Answer 11 · 2019-10-07T18:01:18.000Z

@Vinzius

Long ago we made the unfortunate choice to return nil in the event that Branch is misconfigured. In a future release, I plan on hiding this and always making sure you get an object back.

Answer 12 · 2019-10-29T21:08:02.000Z

I believe this issue should be closed as this issue is fixed in v0.29.1.

Answer 13 · 2019-11-18T15:41:50.000Z

This is still an issue in 4.2.1?

Answer 14 · 2019-11-18T19:17:35.000Z

@macnibblet Are you using React Native? It hasn't been updated yet.

Answer 15 · 2019-12-09T11:16:10.000Z

@echo-branch Makes sense, any chance we can see react native being upgraded since I cannot see build errors in gitlab-ci because the logs generated from these errors are so large gitlab cuts them off.

Answer 16 · 2020-01-15T04:20:04.000Z

We are using react native too, can you update the podspec in it and point it to a latest version.
There are thousand of nullability warning which breaks our CI logs, as it is cutting them off, and we can't scroll to the bottom of the logs.