BrewPi/brewpi-www

Add button to start a new beer

Closed this issue · 4 comments

elcojacobs commented

The interface for starting a new beer is not user friendly: going into maintenance panel, typing the beer name.

A more intuitive way should be added. I was thinking about the following:

  • The beer name becomes clickable
  • Clicking on the beer name opens a pop op menu with the following options:
    • On top: you are currently fermenting .....
    • Stop logging data button (we should have a special beer name that doesnt log any data)
    • Start a new beer
    • Continue existing beer
    • Erase data for this beer and start over
    • (Rename this beer) -> dangerous, we could leave this out for the coming release

There is not really a place for another button to open this menu. Maybe just a small icon next to the beer name is enough to make it clear that it can open a menu.

bschwinn commented

we could rework the right side of the header a bit, where the start/stop and maint buttons are.

maybe make the buttons a "four pack" with two new ones: "Start New Beer" and "Edit Beer" (on the inside of the other two)

Start new beer pulls up a dialog with beer name, mode and profile/SPs based on selected mode. Hitting OK clears data and sends commands to the controller.

Edit Beer pulls up a dialog with buttons to erase data, save data and pause/resume data logging.

So, two new buttons and two new dialogs - hopefully noticeable but not jammed in there

elcojacobs commented

I started with a dialog to update the beer name. Please take a look.

bbaebb2

This is just the start of a nested dialog. It is not implemented on the script side yet. The script needs to answer with a status/result, which can also be displayed in the dialog.

The menu is opened by clicking on the beer name for now. The changes you describe are a bigger UI redesign. Let's postpone it for now and decide on something simple to be able to release the new profile interface.

elcojacobs commented

I have worked on the code some more and also implemented the script side of things.
I must admit it could be prettier. I am running into design flaws of the original code (for example not returning status for all messages and to be honest the whole socket protocol).

Anyway, I think this works for starting, stopping and pausing data logging. Which should be enough for this release. Can you give it a test and review the code?

https://github.com/BrewPi/brewpi-www/tree/feature/startbeerbuttons
https://github.com/BrewPi/brewpi-script/tree/loggingstoppause
(sorry for the inconsistent branch names)

elcojacobs commented

Merged into master with 0.3.
Clicking brew name opens the menu