Installation of new version results in duplicates of recipes and ingredients

Question

Installation of new version results in duplicates of recipes and ingredients

Closed this issue 10 days ago · 4 comments

The first time you launch after installing a new version, things go fine. The second time you launch the program, you'll be prompted to upgrade/add again. And you'll see at least one duplicate of each recipe and/or ingredient.

Answer 1 · 2024-11-28T00:10:03.000Z

Thanks for letting me know about this. The system is supposed to skip over duplicates when it reads in new ingredients, recipes and so on, but it's obviously failing to do so. I'll dig into what's going on and come up with a fix.

Answer 2 · 2024-11-28T15:48:46.000Z

I think I know what the cause of this is. I know how to fix it, but it's a bit of work to do it cleanly. (It's to do with when one object is owned by another -- eg a Recipe owns its "ingredient addition" records, but not its Style or equipment records. At the moment, we do a special case for each "owned" type, and are missing some special cases. The correct fix is to extend the work we already did on generalising ownership so that it's picked up in the XML and JSON import code.) TLDR is I hope to have a fix in the next week to ten days.

Answer 3 · 2024-11-28T16:19:48.000Z

Thanks a bunch for the update.

Answer 4 · 2024-12-18T17:40:10.000Z

Hopefully this is fixed in 4.0.12. If not, please don't hesitate to reopen this issue!

(You will see several seeming duplicates of one of the equipment profiles, but that's because they actually have a different value in pre-boil top-up (IIRC). In the long-run we'll take this field off equipment because it's more of a recipe attribute than an equipment one.)