Build fails with go 1.12 due to `go vet -shadow` in Makefile
Closed this issue · 3 comments
jamesquilty commented
So, the go developers decided to remove the "experimental" checker shadow (see golang/go/issue/29260 and references therein). This means that the Makefile throws an error at line 69 where it tries to run @$(GO) vet -shadow $(PKGS):
Running GOVET
vet: flag "-shadow" not defined
Run "go help vet" for more information
make: *** [govet] Error 2
Taking the brualist approach and deleting that line allowed the build to complete. It would be great if the Makefile was corrected at source, please.
hanzei commented
Downstreaming the latest makefile from https://github.com/mattermost/mattermost-plugin-sample/blob/master/Makefile will help.
medzoom commented
sorry, dont understand to downstream the makefile? in the directory of mattermost-plugin-disable-dm are a bunch of Makefiles?
actually I dont have the mattermost-plugin-sample not installed?
best regards
hanzei commented