Minor: The exported video resolution should follow the input image on the CLI
Closed this issue · 1 comments
This can be counter-intuitive but there's good reasoning on why this happens internally on the code, more information on this #46 (comment).
The culprit lines are these ones, they are there so when batch exporting in shaderflow, scales don't reapply like shaderflow batch main --render --batch 0-3 --scale 0.5, this would halve the resolution of each exported video consecutively.
A workaround is to know beforehand the resolution of your image and send a component of it to the render command. Not the most convenient, and also not a breaking thing :)
Surely there's some better ways to manage this, perhaps defining a self.base_resolution that is the default one, and is used on this resize; then depthflow should set it to the input image's size (and upscaled ones).
I have high confidence that this is fixed in BrokenSource/ShaderFlow@9c445d3 and e92d8ac
batch exporting with custom scale and/or optional width or height, ssaa looks good
will be part of a future release!