Bubobubobubobubo/sardine

Cannot play SuperDirt samples 808 and 909 with an index

Closed this issue · 4 comments

Pa * d('808') is played correctly but Pa * d('808:0') generated an error:

ValueError: Cannot pattern an empty sequence: []

Same for Pa * d('909') and Pa * d('909:0').

All other samples play correctly.

Please note that 808 and 909 are the only SuperDirt samples without at least a letter in their names.

Hi! Yes, this is unfortunate but it is due to the way the base pattern language is working in Sardine. Some other patttern language features are hindering the possibility to use sample folders whose names are based only on numbers.

I took the habit of renaming the few problematic ones. It's better than loosing the ability to work with numbers in the pattern itself :)

I think that deep down, there is a pattern language rule conflicting in such cases, I don't remember which one exactly!

Got it.

In that case, you should change the corresponding line in 6.3. Synths / Samples

Pa * d('808:[0:5,1]', p=0.5, room=1,size=0.5,dry=0.4)

should be removed or restricted to

Pa * d('808', p=0.5, room=1,size=0.5,dry=0.4)

Done : 3f96c93. Thanks for catching this one!

It is now possible to use numbers only for sample names:

Pa * d("808", n="0~20", p=0.5)
Pb * d(". 808", n="10~20", p="0.25|0.5", speed="[1:4]")

I'm closing this issue, please re-open a new one if needed.