duplicating tx match of the same order causes bad block
ngtuna opened this issue · 1 comments
ngtuna commented
DEBUG[09-03|06:56:59] verify matching transaction txHash=b5734a…407d41
DEBUG[09-03|06:56:59] verify matching transaction found a TxMatches Batch numTxMatches=1
DEBUG[09-03|06:56:59] process tx match order="&{Quantity:+100000000000000000 Price:+15000000000000000000000 ExchangeAddress:[13 58 177 75 186 211 217 159 66 3 189 122 17 172 185 72 130 5 14 126] UserAddress:[143 177 4 126 135 77 46 71 44 208 137 128 255 131 131 5 61 216 49 2] BaseToken:[77 126 162 206 148 146 22 214 177 32 243 170 16 22 65 115 97 90 43 108] QuoteToken:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1] Status:NEW Side:SELL Type:LO Hash:[229 134 9 67 24 111 226 58 87 139 138 153 193 157 221 214 146 29 114 242 23 188 196 233 73 228 120 44 153 246 91 232] Signature:0xc00bd57a90 FilledAmount:+0 Nonce:+8 MakeFee:+1 TakeFee:+1 PairName:BTC/TOMO CreatedAt:1567493806 UpdatedAt:1567493806 OrderID:0 NextOrder:[] PrevOrder:[] OrderList:[] Key:}"
...
DEBUG[09-03|06:56:59] verify matching transaction txHash=c024fa…121e23
DEBUG[09-03|06:56:59] verify matching transaction found a TxMatches Batch numTxMatches=1
DEBUG[09-03|06:56:59] process tx match order="&{Quantity:+100000000000000000 Price:+15000000000000000000000 ExchangeAddress:[13 58 177 75 186 211 217 159 66 3 189 122 17 172 185 72 130 5 14 126] UserAddress:[143 177 4 126 135 77 46 71 44 208 137 128 255 131 131 5 61 216 49 2] BaseToken:[77 126 162 206 148 146 22 214 177 32 243 170 16 22 65 115 97 90 43 108] QuoteToken:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1] Status:NEW Side:SELL Type:LO Hash:[229 134 9 67 24 111 226 58 87 139 138 153 193 157 221 214 146 29 114 242 23 188 196 233 73 228 120 44 153 246 91 232] Signature:0xc00664a820 FilledAmount:+0 Nonce:+8 MakeFee:+1 TakeFee:+1 PairName:BTC/TOMO CreatedAt:1567493806 UpdatedAt:1567493806 OrderID:0 NextOrder:[] PrevOrder:[] OrderList:[] Key:}"
thanhnguyennguyen commented
As #674 force adding matching transaction to block.
Removing pending orders right after processing /validation is not necessary and causes unexpected issue.
Reverting #667 in #717 at commit BuildOnViction/tomochain@c5d9abf