BuilderIO/builder

makeStateKey deprecation causes builder.io not to build in an Angular 18 project

jakehockey10 opened this issue · 10 comments

jakehockey10 commented

Describe the bug
A clear and concise description of what the bug is.

It seems that the makeStateKey function is no longer exported from @angular/platform-browser, but instead is importable from @angular/core in the directive builder-content.directive.ts. If you manually change the import from @angular/platform-browser to @angular/core in your local project's node_modules/@builder.io/angular/fesm2020/builder.io-angular.mjs, the project can build again.

To Reproduce
Steps to reproduce the behavior:

  1. Upgrade project to Angular 18
  2. Attempt to build project with ng build
samijaber commented

Thanks for raising this issue.

Worth noting that we are actively working on our Gen2 Angular SDK which will be fully compatible with the latest versions of Angular (17+). It will be launching in beta in the near future.

  • 👍1
jakehockey10 commented

That's awesome! Can you point me to anything public that I can keep tabs on to prevent opening unnecessary issues in the future? I apologize for wasting anyone's time

DzmVasileusky commented

@samijaber

Are you going to add an Angular 18 support for Gen1?
We are using it in production and just switching to Gen2 beta doesn't seem something safe since it is still beta.

samijaber commented

@jakehockey10 One easy way is to watch out for Angular gen2 SDK releases here: https://github.com/BuilderIO/builder/releases?q=sdk-angular&expanded=true

it is currently at 0.0.x, but you will see a clear announcement once it is in Beta (and subsequently in v1).

@DzmVasileusky Correct, Gen2 is still in the early stages and cannot currently replace gen1.
We've made a note that some folks still need Gen1 to support angular 18, and will let you know here when there is an update on this.

  • 🎉1
  • 👀1
DzmVasileusky commented

@samijaber Thank you, It would be great to have full Gen1 support until Gen2 stable release.

neilsoult commented

would you be willing to accept a pull request for this? We'd love to be able to unblock our team from upgrading to angular 18, and changing import paths seems like it should be a trivial change

  • ❤️5
nidaxnido commented

I have the same issue on @builder.io/angular. I updated using npm and the latest version is 3.0.2. Is there any way to upgrade to version 4?

samijaber commented

@nidaxnido That was a publishing error on our part. Sorry about that.

You can upgrade by specifically installing npm install @builder.io/angular@4.0.0.

samijaber commented

@nidaxnido we just fixed the tags: 4.0.0 is back to being the correct latest https://www.npmjs.com/package/@builder.io/angular?activeTab=versions

Thank you for pointing out the issue.