BuoyantIO/slow_cooker

QPS calculation seems off

stevej opened this issue · 2 comments

stevej@netty-test-8:~$ ./slow_cooker_linux_amd64 -qps 150 -concurrency 50 -interval 10s -reuse
2016-06-01T22:33:00Z  83102/0/0 requests  49666 kilobytes 10s [  1   4   7   34 ]
2016-06-01T22:33:10Z  83365/0/0 requests  49823 kilobytes 10s [  2   4   7   14 ]
2016-06-01T22:33:21Z  83318/0/0 requests  49795 kilobytes 10s [  2   4   7   15 ]

The target qps intended was 7,500, not 8,333. Time for some unit tests!

stevej@netty-test-8:~$ ./slow_cooker_linux_amd64 -qps 134 -concurrency 75 -interval 10s -reuse
2016-06-01T22:37:09Z 106811/0/0 requests  63836 kilobytes 10s [  3   6  10   22 ]
2016-06-01T22:37:20Z 107142/0/0 requests  64034 kilobytes 10s [  3   6  10   19 ]

Intended target is 10,050, not 10,700.

Ok, this is due to rounding when the qps calculation is not a whole number.