Inconsistent behavior with negation pattern in `.gitignore`

Question

Inconsistent behavior with negation pattern in `.gitignore`

Nadrieril opened this issue 4 months ago · 8 comments

Nadrieril commented 4 months ago

Please tick this box to confirm you have reviewed the above.

I have a different issue.

What version of ripgrep are you using?

ripgrep 13.0.0
-SIMD -AVX (compiled)
+SIMD +AVX (runtime)

How did you install ripgrep?

Using nix

What operating system are you using ripgrep on?

NixOS 23.11

Describe your bug.

See below. Feels related to #1050 but I think they're different.

What are the steps to reproduce the behavior?

Make a repo with:

.gitignore

build/
!/some_dir/build/

some_dir/build/foo

string

What is the actual behavior?

> rg -l string
some_dir/build/foo
> rg -l string some_dir
# nothing
> rg -l string some_dir/build
some_dir/build/foo

What is the expected behavior?

rg -l string some_dir should find the file too.

Answer 1 · 2024-02-07T18:32:02.000Z

Please try the latest release of ripgrep.

Answer 2 · 2024-02-07T22:08:45.000Z

Oh, sorry, that appears to be fixed in 14.0

Answer 3 · 2024-02-07T22:15:21.000Z

Ah nope, still a bug but it requires one more level of nesting:

ripgrep 14.1.0

features:-simd-accel,-pcre2
simd(compile):+SSE2,-SSSE3,-AVX2
simd(runtime):+SSE2,+SSSE3,+AVX2

PCRE2 is not available in this build of ripgrep.

.gitignore

build/
!/some_dir/subdir/build/

some_dir/subdir/build/foo

string

What is the actual behavior?

> rg -l string
some_dir/subdir/build/foo
> rg -l string some_dir
# nothing
> rg -l string some_dir/subdir
some_dir/subdir/build/foo
> rg -l string some_dir/subdir/build
some_dir/subdir/build/foo

Answer 4 · 2024-02-11T20:16:03.000Z

I can reproduce this with the ignore crate directly and

use ignore::Walk;
fn main() {
    for result in Walk::new("./some_dir") {
        match result {
            Ok(entry) => println!("{}", entry.path().display()),
            Err(err) => println!("ERROR: {}", err),
        }
    }
}

(with the CWD in the directory with the .gitignore)

Answer 5 · 2024-02-11T20:21:47.000Z

This is probably a duplicate of an existing bug, but they are difficult to find.

There are several open issues related to gitignore support that I don't plan on fixing until I've had a chance to rethink the ignore crate from first principles. It might happen within the next year.

Answer 6 · 2024-02-15T10:08:03.000Z

I found a similar bug when using wildcards in .gitignore. Let me know, if I should open a new issue.

Script to reproduce the bug:

#!/usr/bin/env sh

mkdir -p bug/foo/bar && cd bug
git init
echo "baz" > foo/bar/baz.txt
echo "/foo/bar/baz*.txt" > .gitignore

rg -l baz
# Output:
# rg: No files were searched, which means ripgrep probably applied a filter you didn't expect.
# Running with --debug will show why files are being skipped.

rg -l baz foo/
# Output:
# foo/bar/baz.txt

Version:

ripgrep 14.1.0

features:-simd-accel,+pcre2
simd(compile):+SSE2,-SSSE3,-AVX2
simd(runtime):+SSE2,+SSSE3,+AVX2

PCRE2 10.42 is available (JIT is available)

Answer 7 · 2024-02-16T09:40:46.000Z

Actually, I just realized that the wildcard isn't even needed. The bug is reproducible with a .gitignore containing /foo/bar/baz.txt (see script in my previous comment).

Answer 8 · 2024-03-22T17:00:51.000Z

It may be worth looking at https://github.com/Byron/gitoxide/tree/main/gix-ignore when refactoring, or somehow pulling in the logic from it as a library.