BurntSushi/ripgrep

Since nightly-2024-02-06 , could not compile with --features 'simd-accel'

PierreAntoineGuillaume opened this issue · 4 comments

PierreAntoineGuillaume commented

Please tick this box to confirm you have reviewed the above.

  • I have a different issue.

What version of ripgrep are you using?

6ebebb2 (current master HEAD, few commits after 14.1.0)

How did you install ripgrep?

Trying to compiling it from source

What operating system are you using ripgrep on?

Ubuntu 20.04.6 LTS

Describe your bug.

Cannot compile

What are the steps to reproduce the behavior?

RUSTUP_TOOLCHAIN=nightly-2024-02-06 cargo build --features 'simd-accel' fails
RUSTUP_TOOLCHAIN=nightly-2024-02-05 cargo build --features 'simd-accel' works

Because:

   --> ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/packed_simd-0.3.9/src/lib.rs:218:5
    |
218 |     platform_intrinsics,
    |     ^^^^^^^^^^^^^^^^^^^ feature has been removed
    |
    = note: SIMD intrinsics use the regular intrinsics ABI now

Then in later nightly version :

invalid ABI: found `platform-intrinsic`

related: rust-lang/rust@ea37e80
rust-lang/rust#117372

I don't know if this is actually a bug.

What is the actual behavior?

Cannot compile

What is the expected behavior?

Can compile

PierreAntoineGuillaume commented

This is more a report and a reference than a real bug, and I will be trying to make a pull request but anything simd-related is way above my knowledge.

BurntSushi commented

As documented in the README, simd-accel requires a Rust nightly compiler because it relies on unstable features. As also documented in the README, the only thing it helps is UTF-16 decoding. So you might want to re-evaluate why you're enabling it in the first place.

I am considering just removing the simd-accel feature because I am absolutely tired of the fact that encoding_rs refuses to use stable APIs for its SIMD features. All of ripgrep's SIMD optimizations for search do not require it. They use stable but platform specific APIs.

In any case, I'm not tracking this issue here. There's an issue for it at the source: rust-lang/packed_simd#359

  • 👍1
BurntSushi commented

I ended up just removing simd-accel altogether because I'm tired of dealing with it. See #2749

  • 🚀1
PierreAntoineGuillaume commented

Really nice !

Thanks for your time, and for your tools too.