C3C0/GravityBox

Polish to statusbar

Closed this issue · 20 comments

If an app sets this flag: SYSTEM_UI_FLAG_LOW_PROFILE
and circle battery is chosen, it is the only symbol not hidden...

And now I know the reason for the clock in statusbar using holo_blue_dark:
When enabled the new setting, then the clock looks too dark, because its tiny lines...
Possible to exclude clock from the color "repair"?

Here a screenshot for the Low profile flag (made in Hangouts)
2013-10-04 10 48 42

And about the clock, it seems like there is no interest in a new option, but then would it not make sense to use the default clock color to get the most stock look possible?

C3C0 commented

I don't understand the second question.

When I use the option to use the battery color for the circe battery, the color of the clock is also changed accordingly. But because the clock is that tiny it seems to dark afterwards. Therefore to be as close at stock as possible (with the checkbox checked) the clock should not be included in the coloring.

C3C0 commented

The difference is not because of a color. It is because when LOW PROFILE mode is on, all icons are hidden and clock + stock battery alpha channel is set to 50%. Circle battery is not affected at all (currently), that's why there's such difference. If you switch to stock battery and check LOW PROFILE you will see that the stock battery get darker together with clock. I will include the circle battery to that LOW PROFILE mechanism so it will behave exactly like stock battery does.

Oh sorry now I get your problem...
the first and the second question are not related beside that it's about the statusbar...

C3C0 commented

In that case, yes. Clock uses the default stock color when icon coloring is disabled.
Or it uses the one from battery icon when "follow stock battery color" option is enabled

:D:D yes, but if one uses the option to extract the blue color from the battery icon, then it uses this color and not the stock one and my request is to exclude the clock from this recoloring even when this option is enabled.

C3C0 commented

Oh man, that was the reason for making that option previously (so the all icon colors are equal) Now you want it to be removed? :D

:D I had a problem with the circle battery. And while looking at the coloring in greater detail I noticed that the clock also uses the lighter color, and I thought the darker color would fit better. But now as I have the darker color on the clock I realized that there is a reason for the lighter color for the clock(It fits better...)

BTW: What is about my other requests? No interest /other things higher priority/not seen at all^^?

C3C0 commented

Most of them were already done. Except for AOKP cursors.

Besides the clock color and the lock tile you are right ;)
That is how to lock the device:
DevicePolicyManager mDPM;
mDPM.lockNow();
Further info: http://developer.android.com/guide/topics/admin/device-admin.html#lock

C3C0 commented

Thanks. It was not a priority since it's mainly a tablet feature.
Normal phones don't use multi-user modes so lock is not needed.

C3C0 commented

Well I see this is something different. But it requires device administration services. I doubt SystemUI has required permissions to use device administration APIs but I might be wrong.

I do use this on my phone sometimes... To access the lockscreen.(power button only disables screen)
But It's not an that important feature...
I'm not into this things, but device administration is granted on demand... and not declared as permission(afaik)
Power toggles does not demand it in permissions but has the feature and requests devices administration on the first time you lock your screen with power toggles.

C3C0 commented

Just tried one app ( https://play.google.com/store/apps/details?id=com.blogspot.androidinspain.LockScreen&hl=en )
and I somewhat can't see any difference. The final effect is exactly the same as when I use Sleep tile.

Moreover, BIND_DEVICE_ADMIN permission is required which SystemUI lacks.

I guess the different is whether the setting : "Settings>Security>On/off locks device" is enabled or not

C3C0 commented

No such option on mine. That explais why I had no clue about such behaviour.

Ok that explains the misunderstandings ...

Shouldn't this be closed after commit fd53164?

In my eyes no, since the clock color is not stock if circle battery follows the "batteryblue".