CAVaccineInventory/help.vaccinate

unchecking "Is Pending Review" should add the "Approved" tag in VIAL

Closed this issue · 4 comments

kimberlyd17 commented

Currently there are 3 ways to approve reports as a QA'er in VIAL:

  1. From the overview, select 1 or more reports and say "Bulk approve reports" in the menu at top
  2. On the report, uncheck the "Is pending review" box and save (along with any other changes, tags or notes)
  3. In the tags section, add the "Approved" tag, and this will also auto-uncheck the box when you save (if you have not already unchecked it).

1 2 and 3 should be equivalent and all end up with an Approved tag and crediting you as the submitter. But, there is a current issue where number 2 does not auto-add the "Approved" tag. It does remove the "Is pending review" and the report publishes, but it doesn't generate a blank Report Review with a date and your name. This makes it not possible to associate the individual reviewer for their approval but the report still publishes. I thought we had filed a ticket for that but I'm not seeing it right now, so I am adding this ticket here.

kimberlyd17 commented

I don't seem to be able to add a label to this? Odd... @alexmv fyi and also could you add the QA label please?

al63 commented

@kimberlyd17 we may want to move this to the VIAL repo, I don't think this is a Scooby thing

kimberlyd17 commented

@al63 my mistake! I will move it (have to figure out how in github).