CEA-COSMIC/pysap

[BUG] Unaccessible Second Generation of Starlet

Opened this issue · 3 comments

fadinammour commented

System setup
OS: macOS v10.14.5
Python version: v3.7.3
Python environment : conda v4.7.10

Describe the bug
In the C++ code, the boolean ModifiedATWT allows the user to switch from the First Generation Starlet to the Second one. However in the associated Python code, he cannot get the filters of the Second Generation because it seems that he does have access to this boolean variable.

Module and lines involved
The missing boolean variable should be an argument of get_mr_filters() in ModOpt/modoptt/signal/wavelet.py. And it can be found in Sparse2D/MR_Filter.cc and its role is explained in the comment of line 851.

Are you planning to submit a Pull Request?

  • Yes
  • No
aymgal commented

Hi! do you plan to add support for 2nd gen starlet ? Same question for Battle-Lemaré wavelet transform, as I know it is implemented in sparse2d (used in glimpse).

sfarrens commented

Hi @aymgal, I am planning to make some updates to PySAP this autumn, so I can look into.

  • 👍2
aymgal commented

That would be awesome, thank you