QU fitting incompatible with Py3.5
Cameron-Van-Eck opened this issue · 2 comments
The QU fitting code uses the new Python format strings, which were added in Python 3.6. Currently the official version requirement is 3.5, so I either need to update the version requirement or remove the format strings. I'm inclined towards the later, but open to other opinions.
Hi @Cameron-Van-Eck ,
My 2c -- I think that 3.6 is a reasonable target for compatibility. 3.5 relatively old now, and has now reached end-of-life (see https://www.python.org/downloads/release/python-350/). Further, I think version managing is pretty straight forward anyway with conda and/or venvs.
I'd also argue that f-strings are worth it!
I removed Python 3.5 from the minimum spec, and from the automatic tests, since it's end-of-life. It looked like there were multiple errors in the QUfitting code when run in Py3.5, so this is less work. I'll just have to update the CANFAR environment to a more modern version of Python...