CIRADA-Tools/RM-Tools

Release Numpy restriction?

AlecThomson opened this issue · 2 comments

We're currently forcing numpy<1.24 in the setup.py.

It would be nice if we could release this requirement, since numpy is now on 1.25 with 1.26 in the pipeline.

@Cameron-Van-Eck do you recall the initial reason for this restriction? Would we need to fix any broken compatibilities?

Yeah, I was just thinking about that in the last two weeks. when numpy 1.24 came out, it broke several versions of astropy, and imposing the numpy version restriction was the easiest fix. Astropy has since updated and is compatible with newer numpy versions again, although there are some permutations of numpy and astropy versions that probably break.

I did some quick tests of newer numpy versions and they seemed to work, but forgot to remove the version restriction. So I think we can go ahead and do that now.

Ok cool, I'll go ahead and action that change. Hopefully the upstream libraries can take better care of the dependancies for us in the future!