CLD2Owners/cld2

Check in tools for generating generated_* files

Opened this issue · 3 comments

Originally reported on Google Code with ID 33

There's a lot of data files that get generated, such as cld_generated_cjk_uni_prop_80.cc
and its ilk. There have been several problems in the past with the generated files
that have necessitated post-generation fixes, e.g.:

https://code.google.com/p/cld2/source/detail?r=155
https://code.google.com/p/cld2/source/detail?r=156
https://code.google.com/p/cld2/source/detail?r=189
https://code.google.com/p/cld2/source/detail?r=192
https://code.google.com/p/cld2/source/detail?r=193

...

And now we have issue 32, which is more of the same. We don't have the templates or
whatever are used to generated these source files checked in; we should. I get that
the actual data is huge and isn't something we'd store in Git, but I'd really like
to see us put the templates/generators into the code base so that we can maintain them
alongside the code that they produce.

High priority because I feel that at this point there is likely drift between the templates
and the code they produce; we should probably get the templates checked in and iterate
on them until they produce exactly the same files that we have today, then proceed
forward with maintenance.

WDYT?

Reported by andrewhayden@google.com on 2015-05-01 08:34:54

Oh, right. I didn't notice (despite it having generated in the name!) that cld_generated_cjk_uni_prop_80.cc
was generated. Let me know if I can help with making/testing a patch to get issue 32
fixed.

Reported by scottmg@chromium.org on 2015-05-01 18:17:39

Reported by andrewhayden@google.com on 2015-06-11 15:54:02

  • Blocking: #26

It would be nice to get this so that folks could solve the C++0x problems with fewer weird hacks.