CLD2Owners/cld2

Add armv8-a support

Closed this issue · 5 comments

Deleted user commented

Originally reported on Google Code with ID 34

On behalf of Milton.Chiang@mediatek.com (cc'd):

--- snip ---
I would like to send a patch to CLD_2 for adding ARMv8a to the supporting list in internal/port.h.
It’s my first time to send patches to CLD_2 project, and I have no idea how to upload
it.

Can you take a look at the attached file to check if this modification is useful? Is
there any issue related to this modification? Also, can you tell me how to upload the
patch properly?

Thanks for your kindly help.
--- snip ---

Reported by andrewhayden@google.com on 2015-05-05 09:46:30

- _Attachment: [0001-cld_2-ARMv8-patch.patch](https://storage.googleapis.com/google-code-attachments/cld2/issue-34/comment-0/0001-cld_2-ARMv8-patch.patch)_
Deleted user commented 
Hi Milton,

Thanks for the patch. This is the right process, just file an issue here in the CLD2
project and attach a patch file like you did. We'll take a look and get back to you.

Looks straightforward, I think the primary concern will be testing it on some real
producion ARM v8-a hardware so that we can verify that the instruction alignment stuff
(and so on) works properly there and doesn't crash.

Jason Riesa (riesa@google.com, cc'd) is the current maintainer of the overall project,
I usually handle stuff for dynamic data loading and Chromium integration.

Reported by andrewhayden@google.com on 2015-05-05 09:50:42

Deleted user commented 
This looks fine to me. Who can test it on an ARM v8 chip? /dick

Reported by dsites@google.com on 2015-05-05 22:07:55

Deleted user commented 
@#2 Milton can test on his ARMv8-A chip. And/or I can help route ARMv8-A hardware to
whomever would like to verify.

Reported by djkurtz@chromium.org on 2015-05-12 02:28:11

Deleted user commented 
I have tested it on our ARMv8-A platform with "armv7a-cros-linux-gnueabi-gcc -march=armv8-a+crc"
and every thing works fine to me.

Reported by milton.chiang0620 on 2015-05-27 00:45:05

Deleted user commented 
Committed as r195. Thanks!

Reported by andrewhayden@google.com on 2015-05-27 07:40:40

  • Status changed: Fixed