c++0x support
jmhodges opened this issue · 1 comments
jmhodges commented
Currently, cld2 fails in c++0x builds with errors like c++11-narrowing. This happens, specifically, by default in bazel builds that include cld2.
It'd be nice to have those cleared up. I'm a little afraid to touch files with "generated" in their name instead of editing their sources. Perhaps, y'all have access to those and can fix up the code?
You can repro the problem with CFLAGS=std=c++0x ./compile.sh and you'll get lots of errors similar to cld_generated_cjk_uni_prop_80.cc:169:9: error: constant expression evaluates to -14 which cannot be narrowed to type 'uint8' (aka 'unsigned char') [-Wc++11-narrowing].
If there sources are somewhere I can get to, I could try to take a whack at this.