Editing preferences from ThreadViewFragment causes crash.

Question

Editing preferences from ThreadViewFragment causes crash.

Closed this issue 11 years ago · 6 comments

Trying to edit preferences from the ThreadViewFragment causes a StackOverflowError.
Logcat dump:

03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): 03-25 15:16:25.643: E/AndroidRuntime(2139): FATAL EXCEPTION: main
java.lang.StackOverflowError
at java.io.ByteArrayOutputStream.expand(ByteArrayOutputStream.java:92)
at java.io.ByteArrayOutputStream.write(ByteArrayOutputStream.java:201)
at java.io.DataOutputStream.writeShort(DataOutputStream.java:192)
at java.io.ObjectOutputStream.writeFieldDescriptors(ObjectOutputStream.java:858)
at java.io.ObjectOutputStream.writeNewClassDesc(ObjectOutputStream.java:1282)
at java.io.ObjectOutputStream.writeClassDescriptor(ObjectOutputStream.java:1299)
at java.io.ObjectOutputStream.writeClassDesc(ObjectOutputStream.java:790)
at java.io.ObjectOutputStream.writeNewObject(ObjectOutputStream.java:1369)
at java.io.ObjectOutputStream.writeObjectInternal(ObjectOutputStream.java:1671)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:1517)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:1481)
at android.os.Parcel.writeSerializable(Parcel.java:1274)
at android.os.Parcel.writeValue(Parcel.java:1233)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:413)
at android.os.Parcel.writeParcelable(Parcel.java:1254)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:418)
at android.os.Parcel.writeTypedList(Parcel.java:1017)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:419)
at android.os.Parcel.writeParcelable(Parcel.java:1254)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:418)
at android.os.Parcel.writeTypedList(Parcel.java:1017)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:419)
at android.os.Parcel.writeParcelable(Parcel.java:1254)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:418)
at android.os.Parcel.writeTypedList(Parcel.java:1017)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:419)
at android.os.Parcel.writeParcelable(Parcel.java:1254)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:418)
at android.os.Parcel.writeTypedList(Parcel.java:1017)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:419)
at android.os.Parcel.writeParcelable(Parcel.java:1254)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:418)
at android.os.Parcel.writeTypedList(Parcel.java:1017)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:419)
at android.os.Parcel.writeParcelable(Parcel.java:1254)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:418)
at android.os.Parcel.writeTypedList(Parcel.java:1017)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:419)
at android.os.Parcel.writeParcelable(Parcel.java:1254)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:418)
at android.os.Parcel.writeTypedList(Parcel.java:1017)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:419)
at android.os.Parcel.writeParcelable(Parcel.java:1254)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:418)
at android.os.Parcel.writeTypedList(Parcel.java:1017)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:419)
at android.os.Parcel.writeParcelable(Parcel.java:1254)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:418)
at android.os.Parcel.writeTypedList(Parcel.java:1017)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:419)
at android.os.Parcel.writeParcelable(Parcel.java:1254)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:418)
at android.os.Parcel.writeTypedList(Parcel.java:1017)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:419)
at android.os.Parcel.writeParcelable(Parcel.java:1254)
at ca.ualberta.cmput301w14t08.geochan.models.Comment.writeToParcel(Comment.java:418)
at andro

Answer 1 · 2014-03-25T16:47:52.000Z

Why don't we just remove settings from threadView Fragment?

Answer 2 · 2014-03-25T16:53:15.000Z

That's one possible solution, but it decreases user-friendliness. What if the user if browsing a thread then wants to change their username so they can edit a comment of their's?

Answer 3 · 2014-03-25T16:57:10.000Z

I agree, I think preferences should be available app-wide. The other solution is to change the editing to work off of android ID instead of hash (and store android ID instead of hash in the model/on elasticsearch and just do the hash calculation on-device for display purposes only)

Answer 4 · 2014-03-25T16:58:14.000Z

This bug also seems to be related to all sorts of other crashes we've been having especially #57

Answer 5 · 2014-03-25T17:03:26.000Z

Yes, it seems to be related to parcelable comments. Which is odd, because I don't understand why it runs at all at that point. There seems to be an infinite recursion happening there, probably related to writing children of a comment to a parcel.

Answer 6 · 2014-03-26T18:46:47.000Z

fixed by changing parcelable constructor of the comment.