Can not build on MacOS arm64 from Release v2.24.0
SangTruongTan opened this issue · 10 comments
Hi,
I've just faced a problem when I tried to build the app for my MacOS. I think that there is a change between v2.23.0 and v2.24.0 (later on). It got the following error and I can by pass it by utilizing the static cast method.
Error:
Project/dlt-viewer/qdlt/qdltconnection.cpp:79:12: error: no viable conversion from 'QDltDataView' to 'QByteArray'
data = dataView + bytes;
Remedy:
diff --git a/qdlt/qdltconnection.cpp b/qdlt/qdltconnection.cpp
index 20277fa..2534105 100644
--- a/qdlt/qdltconnection.cpp
+++ b/qdlt/qdltconnection.cpp
@@ -75,7 +75,7 @@ void QDltConnection::add(const QByteArray &bytes)
{
bytesReceived += bytes.size();
- data = dataView + bytes;
+ data = static_cast<QByteArray>(dataView) + bytes;
Thanks a lot! This solved the same issue I faced.
Where exactly is you issue ? I just created a new version https://github.com/COVESA/dlt-viewer/releases/tag/v2.25.0 and it builds for macOS, at least for x86
I'm using Apple Silicon, and it's also experienced on v2.25.0 again with the same point.
I applied this change in #369
But locally on my M1 I still run into
Even on CI https://github.com/COVESA/dlt-viewer/actions/runs/5839431094/job/15837605503?pr=369 it runs into the same error
@SangTruongTan
Please can you make a pull request to demonstrate, what exactly needs to be done ?
Hi @hannesa2,
It's very strange, that's the only change at my end. Did you try flushing cmake cache?
I believe it's a clean version I have just done it so far. The remedy is also working with @Hit2theMo.
This overload operator is supposed to fix the issue by just static_cast. Please check at your end.Reopen as fix is not working.
Please check at your end.
There is nothing to check on my send. Simple look at CI #369 and the resulting error
Fixed by the remedy: 4bb3b26