CRED-CLUB/neopop-web

Link Button has no semantics that actually make it a "Link"

Opened this issue · 3 comments

ccsCoder commented

Describe the bug
Button kind = link has zero semantics. In fact it is rendered with <div class="styles__TypographyWrapper-sc-1n7hass-0 cICjag font sans-serif" font-size="11" font-weight="500" color="#0d0d0d">Link</div>, which does not describe itself as a true "Link".

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Button Demo'
  2. Inspect Link and try checking its accessibility properties.
  3. Note that it is rendered using a div and not as an Anchor.

Expected behavior
I would expect Links to render with Anchor tags with a proper Href etc.

Screenshots
DOMSHOT

<div class="styles__TypographyWrapper-sc-1n7hass-0 cICjag font sans-serif" font-size="11" font-weight="500" color="#0d0d0d">Link</div>

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome/ Safari
Kota-Karthik commented

@bigint @ccsCoder @harish-sethuraman
I am interested in doing this issue
So kindly assign me this
Thank you :)

Kiranravi10X commented

Button Render Like this Right?

image