Covering grammar naming
ajmalanoski opened this issue · 4 comments
ajmalanoski commented
As it stands, the covering grammar files in data/cg/tsv
are just named <lng>.tsv
, where <lng>
is the three-letter language code. I think the file names should for the CGs should match those used for the data they correspond to, that is, they should phonetic/phonemic status and script name.
kylebgorman commented
+1
ajmalanoski commented
On a related note, the .phones
files also do not include the script in their filenames. They probably should, though, right? @kylebgorman
kylebgorman commented
No, don't think they need that, since they only refer to the pron side?
…On Fri, Mar 26, 2021 at 2:23 PM Aidan Malanoski ***@***.***> wrote:
On a related note, the .phones files also do not include the script in
their filenames. They probably should, though, right? @kylebgorman
<https://github.com/kylebgorman>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/kylebgorman/wikipron/issues/385#issuecomment-808428076>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABG4OIHXTICSG2DXXFIIVLTFTGK3ANCNFSM4ZUFBT3A>
.
ajmalanoski commented
Oh duh, very true