CXuesong/WikiClientLibrary

Coordinate query fails on some thread cultures

Firedragonweb opened this issue · 3 comments

Since the GeoSearchGenerator uses standard ToString for coordinate latitudes and longitudes, the api returns invalid coordinates, if the current thread culture is set to a culture, where decimal places are separated using a comma "," instead of a point ".".
I suggest using the ToString overload with a CultureIdentifier and using InvariantCulture in all relevant places.

Published v0.6.5. Hope it helps!

Great, thanks a lot! I should have mentioned I have a workaround (temporarily changing the threads culture) so it wasn't that urgent. But great job anyway!

Or you may always implementing your own PageGenerator by slightly change the GeoSearchGenerator source code a bit ^_^

Since the issue is addressed, I will close it for now.