Support for Gnome 45
Closed this issue · 18 comments
It would be great to see this extension work in Gnome 45.
Since I have no Gnome 45 installed yet, I tried a blind version only. Will you help me, trying it? Could you find some mention in syslog to see whether there is an error I could easily spot?
Anyone had the chance to try the Gnome 45 branch to see whether that works?
Oh, sorry. I only saw now that you had replied. I have ported my very small extension to Gnome 45. For testing I used Gnome Boxes. But it is admittedly a bit cumbersome.
It wont work automatically. But there are good porting guides: https://youtu.be/OBnMl8Jk_Rg?si=CV4HEmWqyb7kwnWw
https://gjs.guide/extensions/upgrading/gnome-shell-45.html#esm
Looking at the code it is probably not that hard. I may give it a try in some days.
I've already implemented it two weeks ago, see the commit to the branch gnome45 ;) Are you able to download it and try it on your system?
OK. I have tested it. It does not run yet but I can send you a pull request when it does.
Does it write something to the syslog? :)
This morning, @teur fixed the import and pushed it into the gnome45 branch https://github.com/CZ-NIC/run-or-raise/tree/gnome45 , check rather that version now, thanks!
You are all too fast for me :-) I just fixed everything on my fork. I also reworked the preferences dialog to use libadwaita. It was too wide and I could not read all the text.
By the way: I used Gnome OS Nightly to test the extension in Gnome 45. The easiest way is probably through Gnome Boxes: https://os.gnome.org/
To answer your question: Does it write something to the syslog?
After the patch of teur the extension functions properly as far as I can see. But the preferences dialog does not open. There is nothing in the syslog but I get an exception shown instead of the prefs dialog:
The settings of extension run-or-raise@edvard.cz had an error:
Error: Version 2.0 of GI module GIRepository already loaded, cannot load version 4.0
Stack trace:
require@resource:///org/gnome/gjs/modules/esm/gi.js:19:23
@gi://GIRepository?version=4.0:3:25
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34
My patch also includes a fix for that.
Oh I'm glad that worked out! I could test it again with the current committed code. Or did you already test it on gnome 45?
I tested it again. I did not get any obvious errors. So I think it is ok.
Looking forward to get Gnome 45 from Manjaro now!
When do you think this will be pushed out to the gnome.extensions site?
(Just few more days, sorry)
Finally submitted and under review by the gnome team
(Released ✓)