CachyOS/linux-cachyos

Bad if in the PKGBUILD

pega2k opened this issue · 2 comments

pega2k commented

Hi!

I think this if is not right,

    ### Disable DEBUG
    # Doesn't work with sched-ext
    # More infos here: https://github.com/CachyOS/linux-cachyos/issues/187
    if [[ "$_cpusched" != "sched-ext" || "$_cpusched" != "cachyos" ]] && [ -n "$_disable_debug" ]; then
        scripts/config -d DEBUG_INFO \

It is disabling DEBUG when _cpusched is sched-ext or cachyos, for not disabling it that must be

if [[ "$_cpusched" != "sched-ext" && "$_cpusched" != "cachyos" ]] && [ -n "$_disable_debug" ]; then

Thanks for the great work.
Greetings, Pega.

ptr1337 commented

We needed to drop the disable_debug flag due changes in archs upstream PKGBUILD, which requires now BPF support.
Should be fixed now:
bc2cf60

pega2k commented

Perfect, just keeping it for LTS.

We needed to drop the disable_debug flag due changes in archs upstream PKGBUILD, which requires now BPF support. Should be fixed now: bc2cf60

Yes, because of that I find out, my compilation of the kernel was giving error on the BFP part and I had "_disable_debug-y" in the PKGBUILD from long time ago and didn't try to change it because I have seen the "if", then why? on second revision I find the error.