[Phone-login] Password validation for phone number not implemented on client side
Closed this issue · 5 comments
oliverroick commented
Steps to reproduce the error
- Sign up using a phone number
- Make the phone number part of the password
Actual behavior
The form is submitted and returned with an error that the password contains the phone number.
Expected behavior
The validation should happen on client side, the form should not be submitted to the server.
MappingKat commented
MappingKat commented
Oh I misread the issue... you can disregard that above comment. @oliverroick, you think that the validation should be sooner?
Edely commented
Hi. I am writing a fix to this bug. For the validation should I consider the country code as part of the phone number or discard it?
valaparthvi commented
@Edely Consider only the phone number, you can discard the country code.
clash99 commented
In progress notes - some of the custom validation is being blocked by django-parsley validation so I'm trying to untangle and simplify the validation of the registration form.