calamari/1.0: hold Tensorflow and Protobuf dependencies

Question

calamari/1.0: hold Tensorflow and Protobuf dependencies

bertsky opened this issue 2 years ago · 6 comments

IIUC ocrd_calamari just broke because of a new protobuf release. Looking at the requirements.txt for calamari-ocr==1.0.5 (the latest on that branch), it unconditionally requires tensorflow and protobuf.

Could we please restrict this, e.g. protobuf<4.0, to support 1.x a little longer?

@mikegerber you also mentioned problems with protobuf in Calamari 2 and Python 3.11, but I guess this is unrelated?

Answer 1 · 2023-04-03T14:20:21.000Z

IIUC ocrd_calamari just broke because of a new protobuf release. Looking at the requirements.txt for calamari-ocr==1.0.5 (the latest on that branch), it unconditionally requires tensorflow and protobuf.

Could we please restrict this, e.g. protobuf<4.0, to support 1.x a little longer?

@mikegerber you also mentioned problems with protobuf in Calamari 2 and Python 3.11, but I guess this is unrelated?

Yes, with my latest tests I had to downgrade protobuf too, for Calamari 2. Couldn't tell which version was needed though. (Calamari 2 is on hold due to the licensing issues.)

Answer 2 · 2023-04-03T15:55:40.000Z

I've worked around the issue in ocrd_calamari 1.0.6 by requiring protobuf < 4.0, but this should be fixed in Calamari 1.x itself (and in Calamari 2,x if there's still a problem - and only to repeat - we can't currently upgrade to 2.x due to the licensing issues #3)

Answer 3 · 2023-08-15T18:20:33.000Z

I've worked around the issue in ocrd_calamari 1.0.6 by requiring protobuf < 4.0

Oh, so you added this workaround for the protobuf dep and another workaround for the numpy deprecations.

So that means now ocrd_calamari and calamari-ocr versions will not be in sync anymore. Shouldn't we rather attempt to solve both problems upstream via PR on the calamari/1.0 branch and then ask for a v1.0.6 there?

Answer 4 · 2023-10-16T17:36:46.000Z

I've worked around the issue in ocrd_calamari 1.0.6 by requiring protobuf < 4.0

Oh, so you added this workaround for the protobuf dep and another workaround for the numpy deprecations.

So that means now ocrd_calamari and calamari-ocr versions will not be in sync anymore. Shouldn't we rather attempt to solve both problems upstream via PR on the calamari/1.0 branch and then ask for a v1.0.6 there?

I've removed the numpy/protobuf workarounds in ocrd_calamari and depend on 1.0.x, >= 1.0.6 instead. Tested on Python 3.7-3.11.

(versions in sync? The versions are only accidently identical.)

Answer 5 · 2023-10-16T17:37:21.000Z

I think this issue can be closed now.