TftpTransfer fallsbacks to default rather than proposed?

tftp.net/Tftp.Net/Transfer/TftpTransfer.cs

Lines 99 to 107 in e3fb64a

    
           internal void FinishOptionNegotiation(TransferOptionSet negotiated) 
        
           { 
        
               NegotiatedOptions = negotiated; 
        
               if (!NegotiatedOptions.IncludesBlockSizeOption) 
        
                   NegotiatedOptions.BlockSize = TransferOptionSet.DEFAULT_BLOCKSIZE; 
        
               if (!NegotiatedOptions.IncludesTimeoutOption) 
        
                   NegotiatedOptions.Timeout = TransferOptionSet.DEFAULT_TIMEOUT_SECS; 
        
           }

Is there a reason behind this? This essentially blows away whatever settings are currently set on TftpTransfer. The TFTP server I am uploading to does not support option negotiation and must have a block size of 256, which is currently not possible as the code stands.

Hi! When the server does not support option negotiation, this code is supposed to fall back to the default TFTP options described in RFC 1350. Per that RFC, any server that does not support option negotiation is supposed to use a block size of 512. Why is your server using a block size of 256? What server are you using? Kind regards, Michael Von: Adam Frisby [mailto:notifications@github.com] Gesendet: Montag, 11. November 2019 17:23 An: Callisto82/tftp.net <tftp.net@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Betreff: [Callisto82/tftp.net] TftpTransfer fallsbacks to default rather than proposed? (#22) https://github.com/Callisto82/tftp.net/blob/e3fb64a64b26c57647775a0e4ae6e87cfaa47301/Tftp.Net/Transfer/TftpTransfer.cs#L99-L107 Is there a reason behind this? This essentially blows away whatever settings are currently set on TftpTransfer. The TFTP server I am uploading to does not support option negotiation and must have a block size of 256, which is currently not possible as the code stands. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#22?email_source=notifications&email_token=AEJW3UV6HQIV5S2NSVPEX73QTGBHXA5CNFSM4JLXYQEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HYOW6LA> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEJW3UWG3N6OYKFUWSSDQBLQTGBHXANCNFSM4JLXYQEA> . <https://github.com/notifications/beacon/AEJW3UQ3BDCX6MGN6KW3B6LQTGBHXA5CNFSM4JLXYQEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HYOW6LA.gif>

You are correct. The current operation is correct according to the spec. This issue should probably be closed. The server I am interacting is on an embedded device. It is very basic and I have no control over it. It does not follow the spec and uses a block size of 256.

It would be nice if this library offered a way to disable negotiation and force certain options.

I know this is a closed issue, but I've run up against a similar issue where the embedded server doesn't support negotiation and even trying to negotiate is causing issues. some way of disabling that altogether would be useful to some people.

	internal void FinishOptionNegotiation(TransferOptionSet negotiated)
	{
	NegotiatedOptions = negotiated;
	if (!NegotiatedOptions.IncludesBlockSizeOption)
	NegotiatedOptions.BlockSize = TransferOptionSet.DEFAULT_BLOCKSIZE;

	if (!NegotiatedOptions.IncludesTimeoutOption)
	NegotiatedOptions.Timeout = TransferOptionSet.DEFAULT_TIMEOUT_SECS;
	}