wheel incorrectly contains `.pyc` files
asottile opened this issue · 3 comments
asottile commented
$ ~/opt/venv/bin/pip download --no-deps tdigest
Collecting tdigest
Downloading https://files.pythonhosted.org/packages/27/41/b714941a6dba3760ddf2c2604daabbb578bcd6063f57ecdbe2c1d8ce4a79/tdigest-0.5.2.1-py2.py3-none-any.whl
Saved ./tdigest-0.5.2.1-py2.py3-none-any.whl
Successfully downloaded tdigest
You are using pip version 19.0.3, however version 19.1.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
$ unzip -l tdigest-0.5.2.1-py2.py3-none-any.whl
Archive: tdigest-0.5.2.1-py2.py3-none-any.whl
Length Date Time Name
--------- ---------- ----- ----
155 2016-08-27 01:30 MANIFEST
4034 2018-03-12 13:33 README.md
1089 2015-03-17 05:04 LICENSE.txt
13056 2018-05-05 13:07 tdigest/tdigest.pyc
861 2017-02-20 02:41 tdigest/test_convergence_of_ks_statistic_over_adding.py
53 2018-05-05 13:24 tdigest/__init__.py
10342 2018-05-05 13:24 tdigest/tdigest.py
248 2018-05-05 13:07 tdigest/__init__.pyc
1827 2018-05-05 13:07 tdigest/__pycache__/test_convergence_of_ks_statistic_over_adding.cpython-27-PYTEST.pyc
4035 2018-05-05 13:25 tdigest-0.5.2.1.dist-info/DESCRIPTION.rst
995 2018-05-05 13:25 tdigest-0.5.2.1.dist-info/metadata.json
8 2018-05-05 13:25 tdigest-0.5.2.1.dist-info/top_level.txt
110 2018-05-05 13:25 tdigest-0.5.2.1.dist-info/WHEEL
4907 2018-05-05 13:25 tdigest-0.5.2.1.dist-info/METADATA
1269 2018-05-05 13:25 tdigest-0.5.2.1.dist-info/RECORD
--------- -------
42989 15 files
wheels should only contain source, though this contains python2.x pyc files
(this is easy to fix, a simple re-release with modern versions of wheel / setuptools / pip will not produce wheels in this manner)
CamDavidsonPilon commented
Ah interesting, thanks for the heads up. I'll follow your fix.
CamDavidsonPilon commented
0.5.2.2 is on PyPI now. Thanks @asottile!
asottile commented
Awesome! Thanks for the quick followup <3