CareF/deepin-dock-plugin-neoweather

Icon in dock size incorrect ...

Closed this issue · 7 comments

@CareF ...

could you please look into this ... seems like you have programmed padding for the icon which has reduced the size of the icon in the dock ... the size was perfect in our earlier weather plugin ... can you make it the same size as in the other plugin ?

deepinscreenshot_select-area_20190202104741

thanks.

@CareF ... Also as you can see the icon in the dock is showing a wrong icon ... and icon meant for 'NA' ... not available ...

CareF commented

I have a theory for size problem. Not sure but I will look into it.
The NA icon usually comes when network connection is bad. Since you have correct forcasts, it's weird. Can I see your log? ("Show log" in the right click menu).

I have a theory for size problem. Not sure but I will look into it.
The NA icon usually comes when network connection is bad. Since you have correct forcasts, it's weird. Can I see your log? ("Show log" in the right click menu).

Here is the log ...
dde-dock-plugin-weather.log

CareF commented

96a8732
I think this should have solved both.

CareF commented

I now remember why I changed dock icon size. I was mostly using efficient mode, but during an early stage I tried fashion mode with hty theme and find it slightly large.
I double-checked this time and realized that hty theme icons are maximized around the image size, while gray theme are not (meaning there's an empty boundary). I remembered you got a set of resized icons for hty theme, but I removed it for better management. Is it possible that you make the gray icons also maximize for the image size and I do some change in source code to make it a better size? That will mean better management of the size.

CareF commented

Also, may I ask if the gray theme icons are your work or somewhere from the internet? I just want to make sure that we won't get into trouble with any copyright issue.

Also, may I ask if the gray theme icons are your work or somewhere from the internet? I just want to make sure that we won't get into trouble with any copyright issue.

hahaha ... don't worry ... 100% created by me !!!
I'll work on resizing the icons ...