CaringCaribou/caringcaribou

Wrong limit for auto-detecting base/extended arbitration ID in send function

kasperkarlsson opened this issue · 1 comments

kasperkarlsson commented

Reported by Bill Hass (@bhass1) through a comment to 481fd94

This patch should check for arb_id > 0x7ff (11-bits) instead of 0xffff (16-bits). This will cause unexpected behavior when using CAN IDs between 0x7ff and 0xffff.

Current implementation: https://github.com/CaringCaribou/caringcaribou/blob/master/tool/can_actions.py

if not is_extended:
  is_extended = arb_id > 0xffff

The limit should be changed to ARBITRATION_ID_MAX (which is defined as 0x7FF)