git submodule instructions incorrect in README?
dentarg opened this issue · 1 comments
dentarg commented
I'm using
$ git --version
git version 2.13.6 (Apple Git-96)
The instructions on https://github.com/lovewithfood/rubocop-rspec-focused#contributing didn't work:
$ git clone git@github.com:lovewithfood/rubocop-rspec-focused.git
Cloning into 'rubocop-rspec-focused'...
remote: Counting objects: 136, done.
remote: Total 136 (delta 0), reused 0 (delta 0), pack-reused 136
Receiving objects: 100% (136/136), 16.39 KiB | 16.39 MiB/s, done.
Resolving deltas: 100% (40/40), done.
$ cd rubocop-rspec-focused
$ git submodule update --init --depth 1 vendor/rubocop
Submodule 'vendor/rubocop' (git://github.com/bbatsov/rubocop.git) registered for path 'vendor/rubocop'
Cloning into '/Users/dentarg/Downloads/rubocop-rspec-focused/vendor/rubocop'...
remote: Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
error: Server does not allow request for unadvertised object 056439490c19ba5e00d16c7206483b73386c788f
Fetched in submodule path 'vendor/rubocop', but it did not contain 056439490c19ba5e00d16c7206483b73386c788f. Direct fetching of that commit failed.
$ find vendor/rubocop
vendor/rubocop
vendor/rubocop/.git
However, I got it working with (I looked how Travis CI did it):
$ git submodule init
Submodule 'vendor/rubocop' (git://github.com/bbatsov/rubocop.git) registered for path 'vendor/rubocop'
$ git submodule update
Cloning into '/Users/dentarg/src/rubocop-rspec-focused/vendor/rubocop'...
Submodule path 'vendor/rubocop': checked out '056439490c19ba5e00d16c7206483b73386c788f'