Why is DS4 unstable?

Question

Why is DS4 unstable?

Opened this issue a year ago · 4 comments

Hi, thanks for your crate which is really helpful for my case!
I wanted to know why is the DualShock4 code considered unstable, and if there is a particular reason why the extended report code is still commented out?

Answer 1 · 2023-08-09T08:00:34.000Z

It's unstable because I never ended up needing a virtual dualshock4. Without practical experience I am not convinced that I've made the right API choices so I compromised by including some of the code but under a feature called unstable to indicate I might change the API (breaking) if I felt like it. That's all really.

Answer 2 · 2023-08-09T18:18:03.000Z

Do you plan to work on it sometime, or otherwise, will you accept to review a PR (#10) to add the DualShock4 support? I've started something on my side since I needed it.

Answer 3 · 2023-08-09T21:47:48.000Z

Yeah I don't mind reviewing your work so it can be included! Right now I'm a bit confused as you have 2 PRs, should I still look at #9 ?

Answer 4 · 2023-08-10T13:32:48.000Z

Oh yes, the other (#10) does not only add support for extended reports but also provides an API to build reports, with butttons and status handling, while #9 only adds support for extended reports. I can close #9 to focus on #10.